Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ccache #749

Closed
wants to merge 5 commits into from
Closed

Fix ccache #749

wants to merge 5 commits into from

Conversation

RayeS2070
Copy link
Contributor

Note: by creating a PR or an issue you automatically agree to the CLA. See CONTRIBUTING.md. Feel free to remove this note, the agreement holds.

fdr400
fdr400 requested changes Nov 8, 2024
View reviewed changes
.github/workflows/docker.yaml Outdated Show resolved Hide resolved
@RayeS2070 RayeS2070 force-pushed the fix-ccache branch 2 times, most recently from 5df5964 to e76b81a Compare November 10, 2024 02:05
@RayeS2070
Copy link
Contributor Author

do I need to open a PR for each template, or do you have a simple method?

@fdr400
Copy link
Member

fdr400 commented Nov 10, 2024

each template

what do you mean by template?

@RayeS2070
Copy link
Contributor Author

that
https://github.com/userver-framework/service_template
https://github.com/userver-framework/uservice-dynconf
https://github.com/userver-framework/pg_service_template
https://github.com/userver-framework/pg_grpc_service_template

@fdr400
Copy link
Member

fdr400 commented Nov 10, 2024

yes, for each template

@RayeS2070
Copy link
Contributor Author

i need sad emoji

@RayeS2070
Copy link
Contributor Author

RayeS2070 commented Nov 10, 2024 •
edited
Loading

stored here:
userver-framework/pg_service_template#63
userver-framework/pg_grpc_service_template#48
userver-framework/uservice-dynconf#55
userver-framework/service_template#81

fdr400
fdr400 requested changes Nov 11, 2024
View reviewed changes
.github/workflows/ci.yml Show resolved Hide resolved
@RayeS2070
Copy link
Contributor Author

and can i close this PR?

@RayeS2070 RayeS2070 closed this Nov 11, 2024
@RayeS2070
Copy link
Contributor Author

better fix applied

@RayeS2070 RayeS2070 deleted the fix-ccache branch November 11, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdr400 fdr400 fdr400 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RayeS2070 @fdr400